-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bool::then_some function #4529
Conversation
5428ed7
to
9f1ab70
Compare
013dc21
to
4759ea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @LucasLvy)
corelib/src/lib.cairo
line 18 at r6 (raw file):
} impl BoolSerde of Serde<bool> {
Don't move now any of the existing impls, just create the new one in the new file.
4759ea4
to
bf91321
Compare
should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 12 files reviewed, 3 unresolved discussions (waiting on @LucasLvy)
corelib/src/boolean.cairo
line 2 at r8 (raw file):
#[generate_trait] pub impl ThenSome<T, +Drop<T>> of ThenSomeTrait<T> {
no reason the next added functions won't be added here.
Suggestion:
pub impl BoolImpl<T, +Drop<T>> of BoolTrait<T> {
corelib/src/lib.cairo
line 101 at r8 (raw file):
} pub mod boolean; use boolean::ThenSome;
remove.
Code quote:
use boolean::ThenSome;
6167937
to
792ab33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 12 files at r7, 2 of 2 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @LucasLvy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @LucasLvy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 11 files at r10, all commit messages.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r9, 11 of 11 files at r10.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @LucasLvy)
Converts a bool in an option
This change is