support for match out of order for enums

[TomerStarkware]

This change is 

[orizi]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1032 at r2 (raw file):

        })
        .collect();
    let variant_map = variant_map?;

Suggestion:

            Ok((enum_pattern.variant.clone(), (enum_pattern, arm_index)))
        })
        .collect::<Result<Vec<_>,_>>()?;

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1117 at r2 (raw file):

        ));
    }
    // Merge arm blocks.

is this exactly the same?
extract to function.

[orizi]

Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @TomerStarkware)

---

crates/cairo-lang-lowering/src/test_data/match line 485 at r2 (raw file):

//! > ==========================================================================

//! > Test out of order extern match arm.

is there a place testing non-diagnostics?
is it this file?

Code quote:

Test out of order extern match arm.

[TomerStarkware]

Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1032 at r2 (raw file):

        })
        .collect();
    let variant_map = variant_map?;

Done.

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1117 at r2 (raw file):

Previously, orizi wrote…

is this exactly the same?
extract to function.

Done.

---

crates/cairo-lang-lowering/src/test_data/match line 485 at r2 (raw file):

Previously, orizi wrote…

is there a place testing non-diagnostics?
is it this file?

add number to differentiate the blocks

[orizi]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 983 at r4 (raw file):

}

// get an unordered map of variants to their corresponding arm index

Suggestion:

/// Returns a map from variants to their corresponding arm index.

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1011 at r4 (raw file):

            Ok((enum_pattern.variant.clone(), (enum_pattern, arm_index)))
        })
        .collect::<Result<UnorderedHashMap<_, _>, _>>()

Is this required? (due to the function ret value)

Suggestion:

            Ok((enum_pattern.variant.clone(), (enum_pattern, arm_index)))
        })
        .collect()

---

examples/fib.cairo line 13 at r4 (raw file):

        A::One(_) => { 1 },
    }
}

remove

Code quote:

fn foo(a: A) -> felt252 {
    match a {
        A::Two(_) => { 2 },
        A::One(_) => { 1 },
    }
}

[TomerStarkware]

Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 983 at r4 (raw file):

}

// get an unordered map of variants to their corresponding arm index

Done.

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1011 at r4 (raw file):

Previously, orizi wrote…

Is this required? (due to the function ret value)

Done.

[orizi]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[orizi]

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)