Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for match on true/false in parser and semantic #4559

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

TomerStarkware
Copy link
Collaborator

@TomerStarkware TomerStarkware commented Dec 13, 2023

This change is Reviewable

@TomerStarkware TomerStarkware force-pushed the tomer/match_boolean branch 2 times, most recently from 4fca604 to ef3428d Compare December 13, 2023 16:17
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@TomerStarkware TomerStarkware force-pushed the tomer/match_boolean branch 4 times, most recently from cf4ded6 to f23416e Compare December 14, 2023 12:33
@TomerStarkware TomerStarkware changed the base branch from tomer/match_otherwise to main December 14, 2023 12:34
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@TomerStarkware TomerStarkware force-pushed the tomer/match_boolean branch 2 times, most recently from 1756c04 to 64de62c Compare December 17, 2023 05:11
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @TomerStarkware)


crates/cairo-lang-semantic/src/expr/semantic_test_data/match line 61 at r3 (raw file):

//! > ==========================================================================

//! > Test match bool

isn't this test testing this feature specifically?

@TomerStarkware TomerStarkware force-pushed the tomer/match_boolean branch 2 times, most recently from 01e91ba to a979cd9 Compare December 17, 2023 08:13
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@TomerStarkware TomerStarkware added this pull request to the merge queue Dec 17, 2023
@TomerStarkware TomerStarkware removed this pull request from the merge queue due to a manual request Dec 17, 2023
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@TomerStarkware TomerStarkware added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit ff2a9de Dec 18, 2023
@orizi orizi deleted the tomer/match_boolean branch December 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants