support for match on true/false in parser and semantic #4559
Conversation
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
2 times, most recently
from
4fca604 to
ef3428d
Compare
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
TomerStarkware
force-pushed
the
tomer/match_otherwise
branch
from
6acecfe to
5c6cc93
Compare
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
4 times, most recently
from
cf4ded6 to
f23416e
Compare
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
2 times, most recently
from
1756c04 to
64de62c
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
from
64de62c to
f3ea41f
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @TomerStarkware)
crates/cairo-lang-semantic/src/expr/semantic_test_data/match line 61 at r3 (raw file):
//! > ========================================================================== //! > Test match bool
isn't this test testing this feature specifically?
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
2 times, most recently
from
01e91ba to
a979cd9
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
from
a979cd9 to
670d01a
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:
TomerStarkware
force-pushed
the
tomer/match_boolean
branch
from
670d01a to
3bee019
Compare
This change is