-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added abi failure + warning for account contract functions. #4575
Conversation
fc4de28
to
ceef0f5
Compare
179552f
to
97608e5
Compare
97608e5
to
de5d102
Compare
9949ba4
to
8f61fbd
Compare
3c65990
to
bc44841
Compare
8f61fbd
to
0b163e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/src/abi.rs
line 261 at r1 (raw file):
.find_attr(db, CONTRACT_ATTR)? .into_iter() .any(|attr| !attr.args.is_empty())
Suggestion:
if submodule_id
.find_attr(db, CONTRACT_ATTR)?
.map_or(false, |attr| attr.args(db).is_empty())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/src/abi.rs
line 261 at r1 (raw file):
.find_attr(db, CONTRACT_ATTR)? .into_iter() .any(|attr| !attr.args.is_empty())
Done.
bc44841
to
15e700b
Compare
0b163e0
to
cedee5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
15e700b
to
10c8a04
Compare
10c8a04
to
12ce3a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
51bea34
to
2ecbb84
Compare
2ecbb84
to
6f20b95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
6f20b95
to
2a1df48
Compare
commit-id:0ce94ba3
2a1df48
to
10b473e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
Stack:
This change is