add support for match on none felt252 numeric values

[TomerStarkware]

This change is 

[orizi]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1223 at r1 (raw file):

    let ty = matched_expr.ty();

    if ty == ctx.db.core_felt252_ty() {

can you make sure (in a test) what happens when we have typed literals? e.g.

match 5_u32 {
   0_felt252 => {}
   _ => {}
}

[TomerStarkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1223 at r1 (raw file):

Previously, orizi wrote…

can you make sure (in a test) what happens when we have typed literals? e.g.

match 5_u32 {
   0_felt252 => {}
   _ => {}
}

Done.

[orizi]

Reviewed 1 of 5 files at r2.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

examples/fib_match.cairo line 2 at r2 (raw file):

// Calculates fib...
fn fib(n: u32) -> u32 {

revert to felt - this makes it much more difficult to read the resulting code.

[orizi]

Reviewed 1 of 5 files at r2.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/test_data/match line 298 at r2 (raw file):

        
        _ => 9,

Suggestion:

        0_u8 => 7,
        1_u8 | 2_u8 => 8,
        _ => 9,

[orizi]

Reviewable status: 1 of 6 files reviewed, 3 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/test_data/match line 388 at r2 (raw file):

        
        _ => 9,

.

Suggestion:

        1_felt252 | 2_u8 => 8,
        _ => 9,

[TomerStarkware]

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-lowering/src/test_data/match line 298 at r2 (raw file):

        
        _ => 9,

Done.

---

crates/cairo-lang-lowering/src/test_data/match line 388 at r2 (raw file):

Previously, orizi wrote…

.

Done.

---

examples/fib_match.cairo line 2 at r2 (raw file):

Previously, orizi wrote…

revert to felt - this makes it much more difficult to read the resulting code.

Done.

[orizi]

Reviewed 1 of 3 files at r1, 1 of 5 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1590 at r4 (raw file):

        let ret_ty = corelib::core_felt252_ty(ctx.db.upcast());
        // TODO(TomerStarkware): use the same type of literal as the input, without the cast to
        // felt252.

Suggestion:

        // TODO(TomerStarkware): Use the same type of literal as the input, without the cast to
        // felt252.

[TomerStarkware]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1590 at r4 (raw file):

        let ret_ty = corelib::core_felt252_ty(ctx.db.upcast());
        // TODO(TomerStarkware): use the same type of literal as the input, without the cast to
        // felt252.

Done.

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)