Added breaking of stack if no longer holding a var as temp.

[orizi]

Closes #4744

---

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-sierra-generator/src/store_variables/state.rs line 152 at r1 (raw file):

            self.known_stack.insert_signed(res, idx);
        } else if let Some(idx) = removed {
            self.known_stack.handle_possible_hole(idx);

is this an optimization to reduce the memory usage of the compiler?

Code quote:

   self.known_stack.handle_possible_hole(idx);

[orizi]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra-generator/src/store_variables/state.rs line 152 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

is this an optimization to reduce the memory usage of the compiler?

no - added an edit in the added test to show what was the result before.

---

crates/cairo-lang-sierra-generator/src/store_variables/test.rs line 869 at r1 (raw file):

            "store_temp<felt252>(100) -> (200)",
            "store_temp<felt252>(101) -> (201)",
            "return(201)",

which is the wrong result.

Suggestion:

            "make_local(102) -> (102)",
            "rename<felt252>(100) -> (200)",
            "rename<felt252>(101) -> (201)",
            "return(201)",

[ilyalesokhin-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion