-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type checks to sturct construct destructure optimizations. #4938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Not needed. |
It is needed since the construct comes after the deconstruct. |
8ce1343
to
e32e344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)
crates/cairo-lang-lowering/src/optimizations/return_optimization_test.rs
line 50 at r2 (raw file):
before = lower_panics(db, function_id, &before).unwrap(); reorganize_blocks(&mut before); optimize_remappings(&mut before);
this was also a bug
optimize_remappings should come first
Code quote:
reorganize_blocks(&mut before);
optimize_remappings(&mut before);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
e32e344
to
cda7e6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @orizi)
This change is