Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checks to sturct construct destructure optimizations. #4938

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

ilyalesokhin-starkware
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented Jan 28, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Jan 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2024
@ilyalesokhin-starkware
Copy link
Contributor Author

Not needed.
Was already checked by the semantic module.

@ilyalesokhin-starkware
Copy link
Contributor Author

It is needed since the construct comes after the deconstruct.

Copy link
Contributor Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)


crates/cairo-lang-lowering/src/optimizations/return_optimization_test.rs line 50 at r2 (raw file):

    before = lower_panics(db, function_id, &before).unwrap();
    reorganize_blocks(&mut before);
    optimize_remappings(&mut before);

this was also a bug
optimize_remappings should come first

Code quote:

    reorganize_blocks(&mut before);
    optimize_remappings(&mut before);

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

Copy link
Contributor Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @orizi)

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit c0eecd2 Feb 12, 2024
42 of 43 checks passed
@orizi orizi deleted the ilya/type_checks branch February 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants