Add cmp::minmax function

[delaaxe]

Will add rest of tests if this is accepted

---

This change is 

[orizi]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @delaaxe)

---

corelib/src/cmp.cairo line 18 at r1 (raw file):

#[must_use]
pub fn min_max<T, +PartialOrd<T>, +Drop<T>, +Copy<T>>(a: T, b: T) -> (T, T) {

add doc

---

corelib/src/cmp.cairo line 23 at r1 (raw file):

    }
    (a, b)
}

Suggestion:

#[must_use]
pub fn minmax<T, +PartialOrd<T>, +Drop<T>, +Copy<T>>(a: T, b: T) -> (T, T) {
    if a > b {
        (b, a)
    } else {
        (a, b)
    }
}

---

corelib/src/test/cmp_test.cairo line 46 at r1 (raw file):

    assert_eq(@min_max(120_u8, 130_u8), @(120_u8, 130_u8), '130 > 120');
    assert_eq(@min_max(200_u8, 150_u8), @(150_u8, 200_u8), '200 > 150');
}

Suggestion:

#[test]
fn test_min_max_u8() {
    assert!(minmax(0_u8, 1_u8) == (0_u8, 1_u8));
    assert!(minmax(5_u8, 7_u8) == (5_u8, 7_u8));
    assert!(minmax(255_u8, 128_u8) == (128_u8, 255_u8));
    assert!(minmax(10_u8, 10_u8) == (10_u8, 10_u8));
    assert!(minmax(0_u8, 0_u8) == (0_u8, 0_u8));
    assert!(minmax(255_u8, 255_u8) == (255_u8, 255_u8));
    assert!(minmax(100_u8, 200_u8) == (100_u8, 200_u8));
    assert!(minmax(1_u8, 2_u8) == (1_u8, 2_u8));
    assert!(minmax(120_u8, 130_u8) == (120_u8, 130_u8));
    assert!(minmax(200_u8, 150_u8) == (150_u8, 200_u8));
}

[delaaxe]

Removed @ signs but not sure it actually compiles locally, can you approve the workflows? if/else suggestion doesn't match style of functions just above

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @delaaxe)

---

corelib/src/test/cmp_test.cairo line 46 at r1 (raw file):

    assert_eq(@min_max(120_u8, 130_u8), @(120_u8, 130_u8), '130 > 120');
    assert_eq(@min_max(200_u8, 150_u8), @(150_u8, 200_u8), '200 > 150');
}

Look at the suggestion exactly, you did something else.
Also, use reviewable so we'd follow the same threads.

[delaaxe]

Oh indeed, fixed. Which file should be edited for documentation?

[orizi]

use reviewable to answer in thread.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @delaaxe)

[delaaxe]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

corelib/src/cmp.cairo line 18 at r1 (raw file):

Previously, orizi wrote…

add doc

can you point to the file pls?

---

corelib/src/cmp.cairo line 23 at r1 (raw file):

    }
    (a, b)
}

doesn't match style of functions above, should I change them all?

---

corelib/src/test/cmp_test.cairo line 46 at r1 (raw file):

Previously, orizi wrote…

Look at the suggestion exactly, you did something else.
Also, use reviewable so we'd follow the same threads.

Done.

[orizi]

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @delaaxe)

---

corelib/src/cmp.cairo line 18 at r1 (raw file):

Previously, delaaxe wrote…

can you point to the file pls?

just here - i know - the other functions don't have proper doc - but that's a good place to start.

---

corelib/src/cmp.cairo line 23 at r1 (raw file):

Previously, delaaxe wrote…

doesn't match style of functions above, should I change them all?

yeah - sure.

[delaaxe]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/cmp.cairo line 18 at r1 (raw file):

Previously, orizi wrote…

just here - i know - the other functions don't have proper doc - but that's a good place to start.

Done.

---

corelib/src/cmp.cairo line 23 at r1 (raw file):

Previously, orizi wrote…

yeah - sure.

Done.

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @delaaxe)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @delaaxe)

a discussion (no related file):
adding @gilbens-starkware for 2nd eye.

---

[gilbens-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @delaaxe)

---

corelib/src/cmp.cairo line 12 at r4 (raw file):

    } else {
        a
    }

Suggestion:

/// # Arguments
/// * `a` - first comparable value
/// * `b` - Second comparable value
/// # Returns
/// * `result` - The smallest of the two values
#[must_use]
pub fn min<T, +PartialOrd<T>, +Drop<T>, +Copy<T>>(a: T, b: T) -> T {
    if a > b {
        b
    } else {
        a
    }

[gilbens-starkware]

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @delaaxe)

---

corelib/src/cmp.cairo line 30 at r4 (raw file):

}

/// Minumum and maximum of the two values.

Suggestion:

/// Minimum a

[delaaxe]

Good catches, fixed!

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

corelib/src/cmp.cairo line 12 at r4 (raw file):

    } else {
        a
    }

Done.

---

corelib/src/cmp.cairo line 30 at r4 (raw file):

}

/// Minumum and maximum of the two values.

Done.

[gilbens-starkware]

Reviewed 1 of 2 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @delaaxe)