Improved performance for ecdsa.

[orizi]

This change is 

[gilbens-starkware]

Reviewed 1 of 6 files at r1, all commit messages.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @orizi)

---

corelib/src/ec.cairo line 92 at r1 (raw file):

        ec_state_add(ref self, :p);
    }
    /// Adds a point to the computation.

Subs

Code quote:

Adds

---

corelib/src/ec.cairo line 129 at r1 (raw file):

        Option::Some(EcPointTrait::new_nz(:x, :y)?.into())
    }
    /// Creates a new EC point from its (x, y) coordinates.

Same below.

Suggestion:

new NonZero EC

[gilbens-starkware]

Reviewed 5 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @orizi)

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

corelib/src/ec.cairo line 92 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Subs

Done.

---

corelib/src/ec.cairo line 129 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Same below.

Done.

[gilbens-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

[gilbens-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 82 at r3 (raw file):

    // Calculate a state with `z * G`.
    let mut zG_state = init_ec.clone();

why clone instead of creating a new one?

Code quote:

let mut zG_state = init_ec.clone();

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 95 at r3 (raw file):

    // Check the `(zG + rQ).x = sR.x` case.
    let mut zG_plus_eQ_state = zG_state.clone();

why clone?

Code quote:

let mut zG_plus_eQ_state = zG_state.clone();

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

corelib/src/ecdsa.cairo line 82 at r3 (raw file):

Previously, ilyalesokhin-starkware wrote…

why clone instead of creating a new one?

much cheaper - it is copyable - but would not like to let people use without noting the differences.

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 95 at r3 (raw file):

Previously, ilyalesokhin-starkware wrote…

why clone?

nvm I see that you are using it twice.

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 108 at r3 (raw file):

    // Check the `(zG - rQ).x = sR.x` case.
    let mut zG_minus_eQ_state = zG_state.clone();

Do you need to clone here? isn't this the last use?

Code quote:

zG_state.clone();

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/ecdsa.cairo line 108 at r3 (raw file):

Previously, ilyalesokhin-starkware wrote…

Do you need to clone here? isn't this the last use?

Done.