fix usages in if let construct #5016
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
a discussion (no related file):
added failing test.
TomerStarkware
force-pushed
the
tomer/fix_if_let_lowering
branch
from
a628a5d to
cc9e35b
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
a discussion (no related file):
Previously, orizi wrote…
added failing test.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)
crates/cairo-lang-lowering/src/test_data/if line 263 at r2 (raw file):
//! > function fn foo(a: myEnum) -> felt252 { if let x = a {
revert
TomerStarkware
force-pushed
the
tomer/fix_if_let_lowering
branch
from
cc9e35b to
b276e44
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-lowering/src/test_data/if line 263 at r2 (raw file):
Previously, orizi wrote…
revert
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
This change is