Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed struct formatting. Closing issue #5032. #5062

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Feb 13, 2024

This change is Reviewable

@orizi orizi enabled auto-merge February 13, 2024 21:54
@orizi orizi linked an issue Feb 13, 2024 that may be closed by this pull request
@orizi orizi force-pushed the orizi/fix-struct-fmt branch from e74f521 to 2beb7f8 Compare February 14, 2024 07:14
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @delaaxe and @gilbens-starkware)


corelib/Scarb.lock line 0 at r1 (raw file):

Previously, delaaxe wrote…

in this file intented?

Done.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @delaaxe)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @delaaxe)

@orizi orizi added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 2d40d93 Feb 14, 2024
42 of 43 checks passed
@orizi orizi deleted the orizi/fix-struct-fmt branch February 14, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: destructuring formatting is off
3 participants