Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enable ap tracking detection bug. #5073

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

gilbens-starkware
Copy link
Contributor

@gilbens-starkware gilbens-starkware commented Feb 15, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


-- commits line 2 at r1:
add a test.

@gilbens-starkware gilbens-starkware force-pushed the gil/local_variables_const_fix branch 2 times, most recently from 8c25e54 to 02fba64 Compare February 15, 2024 13:19
Copy link
Contributor Author

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)


-- commits line 2 at r1:

Previously, orizi wrote…

add a test.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


tests/bug_samples/enable_ap_tracking_aliasing.cairo line 16 at r2 (raw file):

#[test]
#[inline(never)]
fn test_contract_address_ordering() {

Suggestion:

}

#[test]
fn test_contract_address_ordering() {

@gilbens-starkware gilbens-starkware force-pushed the gil/local_variables_const_fix branch from 02fba64 to ea4cd66 Compare February 15, 2024 13:41
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@gilbens-starkware gilbens-starkware added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 15, 2024
@gilbens-starkware gilbens-starkware added this pull request to the merge queue Feb 15, 2024
Merged via the queue into dev-v2.6.0 with commit 9144dfc Feb 15, 2024
43 checks passed
@orizi orizi deleted the gil/local_variables_const_fix branch February 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants