Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enable gas to cairo-test #5288

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

maciektr
Copy link
Collaborator

@maciektr maciektr commented Mar 20, 2024

This change is Reviewable

@maciektr maciektr requested review from mkaput, ArielElp and orizi and removed request for ArielElp March 20, 2024 10:18
@maciektr maciektr force-pushed the maciektr/cairo-test-gas branch from dcda26d to fe38492 Compare March 20, 2024 10:19
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)


crates/bin/cairo-test/src/main.rs line 59 at r1 (raw file):

    #[clap(short, long, default_value_t, value_enum)]
    run_profiler: RunProfilerConfigArg,
    /// Should enable gas calculation.

should this affect all gas operations?
no auto-gas addition and so on?

Code quote:

    /// Should enable gas calculation.

@maciektr
Copy link
Collaborator Author

crates/bin/cairo-test/src/main.rs line 59 at r1 (raw file):

Previously, orizi wrote…

should this affect all gas operations?
no auto-gas addition and so on?

Yes, this actually should affect both. I will update this to include compilation as well. Sorry, I thought about running only, because that's what we use in Scarb.

@maciektr maciektr force-pushed the maciektr/cairo-test-gas branch from fe38492 to 95cebb9 Compare March 20, 2024 14:24
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)


crates/cairo-lang-test-runner/src/lib.rs line 304 at r2 (raw file):

}

pub struct RunTestsFlags {

doc (including fields)

Copy link
Collaborator Author

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-test-runner/src/lib.rs line 304 at r2 (raw file):

Previously, orizi wrote…

doc (including fields)

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)


crates/cairo-lang-test-runner/src/lib.rs line 304 at r2 (raw file):

Previously, maciektr (maciektr) wrote…

Done.

missing push probably

@maciektr maciektr force-pushed the maciektr/cairo-test-gas branch from 95cebb9 to 7841353 Compare March 20, 2024 14:50
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @maciektr)

@maciektr maciektr force-pushed the maciektr/cairo-test-gas branch from 7841353 to 34cfe13 Compare March 20, 2024 14:58
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @maciektr)

@maciektr maciektr added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 2637cef Mar 20, 2024
43 checks passed
@orizi orizi deleted the maciektr/cairo-test-gas branch April 17, 2024 16:29
shramee pushed a commit to shramee/cairo that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants