-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to enable gas to cairo-test #5288
Conversation
dcda26d
to
fe38492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)
crates/bin/cairo-test/src/main.rs
line 59 at r1 (raw file):
#[clap(short, long, default_value_t, value_enum)] run_profiler: RunProfilerConfigArg, /// Should enable gas calculation.
should this affect all gas operations?
no auto-gas addition and so on?
Code quote:
/// Should enable gas calculation.
Previously, orizi wrote…
Yes, this actually should affect both. I will update this to include compilation as well. Sorry, I thought about running only, because that's what we use in Scarb. |
fe38492
to
95cebb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)
crates/cairo-lang-test-runner/src/lib.rs
line 304 at r2 (raw file):
} pub struct RunTestsFlags {
doc (including fields)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-test-runner/src/lib.rs
line 304 at r2 (raw file):
Previously, orizi wrote…
doc (including fields)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)
crates/cairo-lang-test-runner/src/lib.rs
line 304 at r2 (raw file):
Previously, maciektr (maciektr) wrote…
Done.
missing push probably
95cebb9
to
7841353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @maciektr)
7841353
to
34cfe13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @maciektr)
This change is