Added handling testing option for get-block-hash.

[orizi]

This change is 

[ArniStarkware]

Reviewed 2 of 4 files at r1.
Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @ArielElp, @gilbens-starkware, and @orizi)

---

corelib/src/starknet/testing.cairo line 77 at r1 (raw file):

pub fn set_block_hash(block_id: u64, value: felt252) {
    cheatcode::<'set_block_hash'>(array![block_id.into(), value].span());
}

Note block id and block number are different.
Not that I understand what block id means in the context of this repo.

Block id - is the address of the block saved to airospike.
Block number - the sequential number of the block in the chain.

Maybe the names were mixed somewhere in the process?

Suggestion:

/// Set the hash for a block.
/// Unset blocks values call would fail.
pub fn set_block_hash(block_number: u64, value: felt252) {
    cheatcode::<'set_block_hash'>(array![block_number.into(), value].span());
}

---

crates/cairo-lang-runner/src/casm_run/mod.rs line 143 at r1 (raw file):

    /// The simulated execution info.
    exec_info: ExecutionInfo,
    next_id: Felt252,

This value is unrelated to get_block_hash, is it?

Code quote:

    next_id: Felt252,

---

crates/cairo-lang-runner/src/casm_run/mod.rs line 144 at r1 (raw file):

    exec_info: ExecutionInfo,
    /// The test provided block hashes.
    block_hash: HashMap<u64, Felt252>,

Is this runner used for something other than tests? The docstring indicates it is not.

Suggestion:

    /// A mock history, mapping block number to the class hash.
    block_hash: HashMap<u64, Felt252>,

[ArniStarkware]

corelib/src/starknet/testing.cairo line 77 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Note block id and block number are different.
Not that I understand what block id means in the context of this repo.

Block id - is the address of the block saved to airospike.
Block number - the sequential number of the block in the chain.

Maybe the names were mixed somewhere in the process?

I see they were only mixed here.

TL;DR: rename block_id -> block_number PLZ.

[orizi]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @ArielElp, @ArniStarkware, and @gilbens-starkware)

---

corelib/src/starknet/testing.cairo line 77 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

I see they were only mixed here.

TL;DR: rename block_id -> block_number PLZ.

Done.

---

crates/cairo-lang-runner/src/casm_run/mod.rs line 143 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This value is unrelated to get_block_hash, is it?

removing in pre-PR.

[ArniStarkware]

Reviewed all commit messages.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @ArielElp and @gilbens-starkware)

[gilbens-starkware]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ArielElp)

[gilbens-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

[ArniStarkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)