-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preventing box values from being const-folded. #5416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2024
Merged
d93953e
to
12358f4
Compare
c56c472
to
9459bb8
Compare
This was referenced Apr 13, 2024
12358f4
to
ebea99c
Compare
176e287
to
d3730d8
Compare
ebea99c
to
c10d2ec
Compare
d3730d8
to
c0819df
Compare
c10d2ec
to
eda0902
Compare
c0819df
to
a95bc09
Compare
eda0902
to
99961f8
Compare
a95bc09
to
696f476
Compare
3bc9341
to
b308fac
Compare
244296d
to
b17a9d3
Compare
b308fac
to
8ae2887
Compare
b17a9d3
to
e6b19aa
Compare
af5a735
to
3bb90f4
Compare
e6b19aa
to
50f0be8
Compare
commit-id:96c96792
3bb90f4
to
13280f4
Compare
gilbens-starkware
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
This change is