Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Implement hover definition for variables & params #5806

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Jun 14, 2024

This change is Reviewable

@mkaput mkaput marked this pull request as draft June 14, 2024 13:58
Base automatically changed from spr/main/9a00fc66 to main June 15, 2024 04:10
@mkaput mkaput force-pushed the spr/main/b02eb1fa branch 2 times, most recently from 6f21c7f to f786847 Compare June 17, 2024 13:32
@mkaput mkaput requested a review from orizi June 17, 2024 13:59
@mkaput mkaput marked this pull request as ready for review June 17, 2024 13:59
@mkaput mkaput force-pushed the spr/main/b02eb1fa branch from f786847 to 979b736 Compare June 17, 2024 14:04
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@mkaput mkaput added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit a2fc407 Jun 17, 2024
43 checks passed
@mkaput mkaput deleted the spr/main/b02eb1fa branch June 17, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants