Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warnings for unused trait imports as well. #6152

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 6, 2024

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware August 6, 2024 12:39
@orizi orizi enabled auto-merge August 6, 2024 12:39
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 45 of 45 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/expr/compute.rs line 1698 at r1 (raw file):

/// call and Index operator differs in the diagnostics they emit. The function returns the
/// function_id to call, the self argument, with snapshots added if needed, and the mutability of
/// the self argument.

Suggestion:

/// call and Index operator differs in the diagnostics they emit. The function returns the
/// function_id to call, the trait containing the function, the self argument, with snapshots added if needed, and the mutability of
/// the self argument.

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-semantic/src/expr/compute.rs line 1698 at r1 (raw file):

/// call and Index operator differs in the diagnostics they emit. The function returns the
/// function_id to call, the self argument, with snapshots added if needed, and the mutability of
/// the self argument.

Done.

@orizi orizi force-pushed the orizi/unused-trait-imports branch from 062a96b to f48cf72 Compare August 6, 2024 13:20
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 846a761 Aug 6, 2024
43 of 44 checks passed
@orizi orizi deleted the orizi/unused-trait-imports branch August 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants