LS: refresh project on cairo_project.toml change, register text document sync on server side

[piotmag769]

This change is 

[mkaput]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)

[Draggu]

Please move this logic into client_capabilities.rs.

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @Arcticae and @orizi)

[mkaput]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lib.rs line 850 at r2 (raw file):

                serde_json::to_value(TextDocumentChangeRegistrationOptions {
                    document_selector,
                    sync_kind: 2, // TextDocumentSyncKind::FULL

but FULL is 1, while INCREMENTAL is 2 according to lsp_types. isn't something off here?

---

crates/cairo-lang-language-server/src/lib.rs line 863 at r2 (raw file):

            for (method, options) in zip(methods, register_options) {
                register_dynamically(method, Some(options), &self.client).await;
            }

I sense overengineering here. Why not just something like this:

Suggestion:

            self.register_dynamic_capability(
                "textDocument/didOpen"
                &text_document_registration_options,
            ).await;
            self.register_dynamic_capability(
                "textDocument/didChange",
                TextDocumentChangeRegistrationOptions {
                    document_selector,
                    sync_kind: 2, // TextDocumentSyncKind::FULL
                },
            ).await;
            self.register_dynamic_capability(
                "textDocument/didSave",
                TextDocumentSaveRegistrationOptions {
                    include_text: Some(false),
                    text_document_registration_options: text_document_registration_options.clone(),
                },
            ).await;
            self.register_dynamic_capability(
                "textDocument/didClose",
                &text_document_registration_options,
            ).await;

---

crates/cairo-lang-language-server/src/lib.rs line 1027 at r2 (raw file):

    let result = client.register_capability(vec![registration]).await;
    if let Err(err) = result {
        warn!("Failed to register {method} event: {err:#?}");

wdyt

Suggestion:

error!("failed to register dynamic capabilities for {method}: {err:#?}");

---

crates/cairo-lang-language-server/src/lsp/client_capabilities.rs line 18 at r2 (raw file):

    fn workspace_configuration_support(&self) -> bool;

    /// The client supports dynamic registration for the `workspace/didChangeWatchedFiles`

fix doc

[piotmag769]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/src/lib.rs line 850 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

but FULL is 1, while INCREMENTAL is 2 according to lsp_types. isn't something off here?

Done.

---

crates/cairo-lang-language-server/src/lib.rs line 863 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

I sense overengineering here. Why not just something like this:

Done, did this before, maybe it is indeed better

---

crates/cairo-lang-language-server/src/lib.rs line 1027 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

wdyt

Done.

---

crates/cairo-lang-language-server/src/lsp/client_capabilities.rs line 18 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

fix doc

Done.

[piotmag769]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae, @mkaput, and @orizi)

[piotmag769]

Will do in a separate PR after we merge relevant stuff

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae, @mkaput, and @orizi)

[mkaput]

Reviewed 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lib.rs line 371 at r4 (raw file):

            register_options: Some(serde_json::to_value(register_options).unwrap()),
        };
        let result = self.client.register_capability(vec![registration]).await;

oh I see now that this support batch registration. could we make use of that?

[piotmag769]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/src/lib.rs line 371 at r4 (raw file):

Previously, mkaput (Marek Kaput) wrote…

oh I see now that this support batch registration. could we make use of that?

Sure, completely missed that

[piotmag769]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @orizi)

[mkaput]

BTW I think we should do a separate server_capabilities.rs

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lib.rs line 419 at r5 (raw file):

                    serde_json::to_value(TextDocumentChangeRegistrationOptions {
                        document_selector,
                        sync_kind: 1, // TextDocumentSyncKind::FULL

Suggestion:

sync_kind: TextDocumentSyncKind::FULL as i32,

[piotmag769]

Done in slightly different way

Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/src/lib.rs line 419 at r5 (raw file):

                    serde_json::to_value(TextDocumentChangeRegistrationOptions {
                        document_selector,
                        sync_kind: 1, // TextDocumentSyncKind::FULL

Cannot be done, it is an impl const, not an enum

[piotmag769]

Reviewed 6 of 6 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @orizi)

[Draggu]

Reviewed 1 of 2 files at r4, 4 of 6 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @mkaput, and @orizi)

[mkaput]

Reviewed 4 of 6 files at r6, 1 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @orizi)

[orizi]

Reviewed 1 of 2 files at r4, 3 of 6 files at r6, 1 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)