-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly printing panics in the cairo runner. #6333
Conversation
0e6cb56
to
55d45eb
Compare
Aren't we supposed to parse from end to start? Code quote: let mut felts = values.into_iter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/bin/cairo-run/src/main.rs
line 118 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Aren't we supposed to parse from end to start?
AFAIU - we should maybe read from end to start - but parse from start to end.
(as the bytearray markers appear before the data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Previously, orizi wrote…
do we want to implement that in the code? |
Previously, ilyalesokhin-starkware wrote…
Parse each entry from start to end but print the entries in reverse order? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
crates/bin/cairo-run/src/main.rs
line 118 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Parse each entry from start to end but print the entries in reverse order?
possibly - in any case - we currently don't do it anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
This change is