-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS: Limit module import completion to visible members #6566
Conversation
f68c34d
to
e919c7a
Compare
e919c7a
to
8186a66
Compare
8186a66
to
c2fca13
Compare
c2fca13
to
e464670
Compare
c812043
to
d43926e
Compare
04cb069
to
d2ba360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @integraledelebesgue, @orizi, and @piotmag769)
crates/cairo-lang-language-server/tests/test_data/completions/module_items.txt
line 18 at r2 (raw file):
fn some_method(self: @T); }
please trim whitespace in empty lines
33b35fb
to
70595cd
Compare
d2ba360
to
c3ab5ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)
crates/cairo-lang-language-server/tests/test_data/completions/module_items.txt
line 18 at r2 (raw file):
Previously, mkaput (Marek Kaput) wrote…
please trim whitespace in empty lines
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)
3f917bb
to
aa88ba2
Compare
dd64173
to
d743d38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)
d743d38
to
f851627
Compare
aa88ba2
to
edb8bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)
f851627
to
f625cc3
Compare
f625cc3
to
f04a69c
Compare
79a7fea
to
8638f37
Compare
9349601
to
ddeeff1
Compare
322fb00
to
5964758
Compare
commit-id:1082e87e
ddeeff1
to
efabc6a
Compare
No description provided.