Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Limit module import completion to visible members #6566

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Oct 31, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@integraledelebesgue integraledelebesgue changed the base branch from spr/main/0051578a to main October 31, 2024 17:28
@integraledelebesgue integraledelebesgue changed the base branch from main to spr/main/0051578a October 31, 2024 17:28
@integraledelebesgue integraledelebesgue changed the base branch from spr/main/0051578a to main October 31, 2024 17:32
@integraledelebesgue integraledelebesgue changed the base branch from main to spr/main/0051578a October 31, 2024 17:32
@integraledelebesgue integraledelebesgue changed the title Changed module import completion to contain only visible members LS: Limit module import completion to visible members Oct 31, 2024
@integraledelebesgue integraledelebesgue force-pushed the spr/main/1082e87e branch 2 times, most recently from 04cb069 to d2ba360 Compare November 4, 2024 09:37
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @integraledelebesgue, @orizi, and @piotmag769)


crates/cairo-lang-language-server/tests/test_data/completions/module_items.txt line 18 at r2 (raw file):

        fn some_method(self: @T);
    }
    

please trim whitespace in empty lines

Copy link
Member Author

@integraledelebesgue integraledelebesgue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)


crates/cairo-lang-language-server/tests/test_data/completions/module_items.txt line 18 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

please trim whitespace in empty lines

Done.

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

@integraledelebesgue integraledelebesgue changed the base branch from spr/main/0051578a to main November 14, 2024 16:31
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Nov 14, 2024
@piotmag769 piotmag769 removed this pull request from the merge queue due to a manual request Nov 14, 2024
@integraledelebesgue integraledelebesgue changed the base branch from main to spr/main/0051578a November 14, 2024 16:50
@integraledelebesgue integraledelebesgue changed the base branch from spr/main/0051578a to main November 14, 2024 16:50
@integraledelebesgue integraledelebesgue changed the base branch from main to spr/main/0051578a November 14, 2024 16:52
@integraledelebesgue integraledelebesgue force-pushed the spr/main/0051578a branch 3 times, most recently from 79a7fea to 8638f37 Compare November 14, 2024 17:09
@integraledelebesgue integraledelebesgue force-pushed the spr/main/1082e87e branch 3 times, most recently from 9349601 to ddeeff1 Compare November 14, 2024 17:55
@integraledelebesgue integraledelebesgue changed the base branch from spr/main/0051578a to main November 14, 2024 18:12
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit a952721 Nov 14, 2024
93 of 94 checks passed
@orizi orizi deleted the spr/main/1082e87e branch November 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: LSP completion dialog should only recommend public members of a module
5 participants