Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with consts defined out of order. #6625

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 11, 2024

Fixed issue #6632

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/const-out-of-order-members branch from a187ffb to 9d32206 Compare November 11, 2024 14:39
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit ccbc7f1 Nov 11, 2024
48 checks passed
@orizi orizi deleted the orizi/const-out-of-order-members branch November 14, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: defining a struct by its member names in a different order than the definition is swapping field values
3 participants