Panic when a dependency is misconfigured.

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/resolve/mod.rs line 1290 at r1 (raw file):

                    get_long_id(dep_crate_id),
                    configs.keys().cloned().map(get_long_id).collect_vec()
                );

Invalid crate dependency: Real { name: "bounded_int2", discriminator: Some("bounded_int") }
Configured crates: [
Real {
name: "core",
discriminator: None,
},
Real {
name: "stwo_cairo_verifier",
discriminator: Some(
"stwo_cairo_verifier",
),
},
Real {
name: "bounded_int2",
discriminator: Some(
"bounded_int2",
),
},
]

Code quote:

                panic!(
                    "Invalid crate dependency: {:?}\nconfigured crates: {:#?}",
                    get_long_id(dep_crate_id),
                    configs.keys().cloned().map(get_long_id).collect_vec()
                );

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/resolve/mod.rs line 1290 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Invalid crate dependency: Real { name: "bounded_int2", discriminator: Some("bounded_int") }
Configured crates: [
Real {
name: "core",
discriminator: None,
},
Real {
name: "stwo_cairo_verifier",
discriminator: Some(
"stwo_cairo_verifier",
),
},
Real {
name: "bounded_int2",
discriminator: Some(
"bounded_int2",
),
},
]

here is an example:

Code snippet:

Invalid crate dependency: Real { name: "bounded_int2", discriminator: Some("bounded_int") }
Configured crates: [
    Real {
        name: "core",
        discriminator: None,
    },
    Real {
        name: "stwo_cairo_verifier",
        discriminator: Some(
            "stwo_cairo_verifier",
        ),
    },
    Real {
        name: "bounded_int2",
        discriminator: Some(
            "bounded_int2",
        ),
    },
]

[orizi]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 1289 at r1 (raw file):

                    "Invalid crate dependency: {:?}\nconfigured crates: {:#?}",
                    get_long_id(dep_crate_id),
                    configs.keys().cloned().map(get_long_id).collect_vec()

oh - we should probably just filter to the relevant crate without discriminator.

Code quote:

                    "Invalid crate dependency: {:?}\nconfigured crates: {:#?}",
                    get_long_id(dep_crate_id),
                    configs.keys().cloned().map(get_long_id).collect_vec()

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 1291 at r1 (raw file):

                    configs.keys().cloned().map(get_long_id).collect_vec()
                );
            }

oh - we should probably just filter to the relevant crate without discriminator.

Suggestion:

                panic!(
                    "Invalid crate dependency `{ident}: got discriminator {:?}\nconfigured discriminators: {:#?}",
                    dep.discriminator,
                    configs.keys().cloned().map(|crate_id|crate_id.lookup_intern(self.db).discriminator).collect_vec()
                );
            }

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 1291 at r1 (raw file):

Previously, orizi wrote…

oh - we should probably just filter to the relevant crate without discriminator.

i mean .filter_map(|crate_id| { let long_id = crate_id.lookup_intern(self.db); (long_id.name == ident).and_then(long_id.discriminator) })

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/resolve/mod.rs line 1291 at r1 (raw file):

Previously, orizi wrote…

i mean .filter_map(|crate_id| { let long_id = crate_id.lookup_intern(self.db); (long_id.name == ident).and_then(long_id.discriminator) })

The name could also be wrong.

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion