Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo Update compile_error.rs #6880

Merged
merged 4 commits into from
Jan 3, 2025
Merged

typo Update compile_error.rs #6880

merged 4 commits into from
Jan 3, 2025

Conversation

Fallengirl
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dimakozak228228)

@orizi orizi enabled auto-merge December 16, 2024 18:22
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakozak228228)


a discussion (no related file):
run ./scripts/rust.fmt as well as
CAIRO_FIX_TESTS=1 cargo t --profile=ci-dev -p cairo-lang-plugins

@Fallengirl
Copy link
Contributor Author

@orizi all good ?

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, your ci breaks, look at the other comment.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakozak228228)

auto-merge was automatically disabled December 23, 2024 17:22

Head branch was pushed to by a user without write access

@Fallengirl
Copy link
Contributor Author

@orizi finish ! thank you

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Fallengirl)

@orizi orizi enabled auto-merge December 23, 2024 18:20
auto-merge was automatically disabled January 3, 2025 11:44

Head branch was pushed to by a user without write access

@Fallengirl
Copy link
Contributor Author

@orizi
@futreall Thanks !

@orizi orizi enabled auto-merge January 3, 2025 11:58
@orizi orizi added this pull request to the merge queue Jan 3, 2025
Merged via the queue into starkware-libs:main with commit 825b42d Jan 3, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants