Changing the prioritization in output Diagnostics.

[Tomer-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 7 of 11 files at r1, all commit messages.
Reviewable status: 7 of 11 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @Tomer-StarkWare, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/test_data/closure line 430 at r1 (raw file):

//! > expected_diagnostics
error: Trait has no implementation in context: core::ops::function::Fn::<{[email protected]:5:15: 5:27}, (core::felt252,)>.

@TomerStarkware - suggestions for a better error?

Code quote:

error: Trait has no implementation in context: core::ops::function::Fn::<{[email protected]:5:15: 5:27}, (core::felt252,)>.

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2792 at r1 (raw file):

            },
        )?;

revert.

[Tomer-StarkWare]

Reviewable status: 7 of 11 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @orizi, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2792 at r1 (raw file):

Previously, orizi wrote…

revert.

Done.

[TomerStarkware]

Reviewed 3 of 11 files at r1, all commit messages.
Reviewable status: 10 of 11 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @orizi, and @Tomer-StarkWare)

---

crates/cairo-lang-semantic/src/expr/test_data/closure line 430 at r1 (raw file):

Previously, orizi wrote…

@TomerStarkware - suggestions for a better error?

this is correct bar can only accept tuple of 3 not tuple of 1, if we want different error we should probably report FnTrait errors differently

---

crates/cairo-lang-semantic/src/expr/inference.rs line 764 at r1 (raw file):

            ));
        }
        if let Some((var, ambiguity)) = self.ambiguous.first() {

maybe ambigious last? or skip WillNotInfer at first and only report it after the types

[orizi]

Reviewable status: 10 of 11 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @Tomer-StarkWare, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/inference.rs line 764 at r1 (raw file):

Previously, TomerStarkware wrote…

maybe ambigious last? or skip WillNotInfer at first and only report it after the types

i agree.

---

crates/cairo-lang-semantic/src/expr/inference.rs line 774 at r1 (raw file):

                return Some((InferenceVar::Type(var.id), InferenceError::TypeNotInferred(ty)));
            }
        }

save and find if it is "will not infer" - and skip if nothing else.

Code quote:

        if let Some((var, ambiguity)) = self.ambiguous.first() {
            let var = *var;
            // Note: do not rewrite `ambiguity`, since it is expressed in canonical variables.
            return Some((InferenceVar::Impl(var), InferenceError::Ambiguity(ambiguity.clone())));
        }
        for (id, var) in self.type_vars.iter().enumerate() {
            if self.type_assignment(LocalTypeVarId(id)).is_none() {
                let ty = TypeLongId::Var(*var).intern(self.db);
                return Some((InferenceVar::Type(var.id), InferenceError::TypeNotInferred(ty)));
            }
        }

[orizi]

Reviewed 1 of 8 files at r2, all commit messages.
Reviewable status: 4 of 11 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @Tomer-StarkWare, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/inference.rs line 775 at r2 (raw file):

                fallback_ret = 
                    Some((InferenceVar::Impl(*var), InferenceError::Ambiguity(ambiguity.clone())));
            }

Suggestion:

            // Note: do not rewrite `ambiguity`, since it is expressed in canonical variables.
            let ret = Some((InferenceVar::Impl(*var), InferenceError::Ambiguity(ambiguity.clone())));
            if !matches!(ambiguity, Ambiguity::WillNotInfer(_)) {
                return ret;
            } else {
                fallback_ret = ret;
            }

[orizi]

Reviewed 1 of 11 files at r1, 7 of 8 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @Tomer-StarkWare, and @TomerStarkware)

[Tomer-StarkWare]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @orizi, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/inference.rs line 775 at r2 (raw file):

                fallback_ret = 
                    Some((InferenceVar::Impl(*var), InferenceError::Ambiguity(ambiguity.clone())));
            }

Done.

[orizi]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @TomerStarkware)

[orizi]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @Tomer-StarkWare, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2763 at r4 (raw file):

            },
        )?;

revert.

[Tomer-StarkWare]

Reviewable status: 10 of 11 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @orizi, and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2763 at r4 (raw file):

Previously, orizi wrote…

revert.

Done.

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @TomerStarkware)

[TomerStarkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)