-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output formatting in cairo-run #6911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Hopium21)
crates/bin/cairo-run/src/main.rs
line 127 at r1 (raw file):
print!(", "); } first = false;
run ./scripts/rust_fmt.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Hopium21)
@orizi I've tested the changes and verified that the output formatting works correctly now. Ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your ci is still broken, run ./scripts/rust_fmt.sh
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Hopium21)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not do actions in this PR if you don't fix all issues at https://reviewable.io/reviews/starkware-libs/cairo/6911
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Hopium21)
@orizi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Hopium21)
Co-authored-by: comfsrt <[email protected]>
File changed: crates/bin/cairo-run/src/main.rs
Before: first = false; // After print!(", ")
After: first = false; // Before print!(", ")
This PR fixes the output formatting of panic messages in the Cairo runner by moving the first = false assignment before printing the comma separator. This ensures proper comma separation between panic values without an unnecessary leading comma.