feat(corelib): add map to Option

[cairolover]

Adds map to OptionTrait for more functional programming features.

moved ok_or to be close to map, regrouping functions by concern (transforming contained values).

adds missing test for ok_or.

[reviewable-StarkWare]

This change is 

[julio4]

@cairolover Maybe we should coordinate to not work on the same things cf #6927 #6928 #6930

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @cairolover)

---

corelib/src/option.cairo line 179 at r1 (raw file):

    /// Transforms the `Option<T>` into a `Result<T, E>`, mapping `Option::Some(v)` to
    /// `Result::Ok(v)` and `Option::None` to `Result::Err(err)`.

why move it?

[cairolover]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/option.cairo line 179 at r1 (raw file):

moved ok_or to be close to map, regrouping functions by concern (transforming contained values).

As we're adding methods to the corelib, I think it's good that we ensure that they're grouped by concern. In that case, ok_or is should be grouped with map.

I would even go as far as moving unwrap with unwrap_or, unwrap_or_default and unwrap_or_else, but that can be for another PR if you agree. It's minor stuff but makes the difference at the end.

Also: if you prefer that I make 1 change per PR instead of adding scout commits, please let me know 😁

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @cairolover)

---

corelib/src/option.cairo line 179 at r1 (raw file):

Previously, cairolover (cairolover) wrote…

moved ok_or to be close to map, regrouping functions by concern (transforming contained values).

As we're adding methods to the corelib, I think it's good that we ensure that they're grouped by concern. In that case, ok_or is should be grouped with map.

I would even go as far as moving unwrap with unwrap_or, unwrap_or_default and unwrap_or_else, but that can be for another PR if you agree. It's minor stuff but makes the difference at the end.

Also: if you prefer that I make 1 change per PR instead of adding scout commits, please let me know 😁

reordering in a different PR would be appreciated - this is more difficult to review this way.

thanks!

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @cairolover)

---

a discussion (no related file):
@TomerStarkware for 2nd eye.

[cairolover]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/option.cairo line 179 at r1 (raw file):

Previously, orizi wrote…

reordering in a different PR would be appreciated - this is more difficult to review this way.

thanks!

Done.

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @cairolover)

---

corelib/src/option.cairo line 265 at r3 (raw file):

    /////////////////////////////////////////////////////////////////////////
    // Transforming contained values
    /////////////////////////////////////////////////////////////////////////

@enitrat should we have such headlines?

Code quote:

    /////////////////////////////////////////////////////////////////////////
    // Transforming contained values
    /////////////////////////////////////////////////////////////////////////

[enitrat]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/option.cairo line 265 at r3 (raw file):

Previously, orizi wrote…

@enitrat should we have such headlines?

This has no impact on the generated doc site, but helps when navigating the source code. I think we could.

[enitrat]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/option.cairo line 265 at r3 (raw file):

Previously, enitrat (Mathieu) wrote…

This has no impact on the generated doc site, but helps when navigating the source code. I think we could.

Rust has this

[TomerStarkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @enitrat and @orizi)

[orizi]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cairolover)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cairolover)

[TomerStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cairolover)