-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: remove variable on Felt252Dict get() #7012
dev: remove variable on Felt252Dict get() #7012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @augustin-v)
a discussion (no related file):
@gilbens-starkware for 2nd eye.
corelib/src/test/dict_test.cairo
line 114 at r1 (raw file):
dict.insert(11, nullable::nullable_from_box(BoxTrait::new(2))); let val10 = dict[10].deref(); let val11 = dict[11].deref();
revert.
cc196b6
to
b0a5208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @augustin-v)
@orizi Thank you for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @augustin-v)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @augustin-v)
The intermediate variable
return_value
in the dictget()
method is redundant since the value implements Copyand can be used both in finalize and return statement without being moved.
Removed an unused variable in the tests as well