vec deprecated append

[dean-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[gilbens-starkware]

Fix the title.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)

[dean-starkware]

What's wrong with it?

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)

[gilbens-starkware]

It's the branch name, not the commit message.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)

[dean-starkware]

I don't see it...

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @dean-starkware)

---

corelib/src/starknet/storage/vec.cairo line 327 at r2 (raw file):

        note: "Use `core::starknet::storage::Vec::MutableVecTrait::allocate` instead",
    )]
    fn append(self: T) -> StoragePath<Mutable<Self::ElementType>>;

Suggestion:

    fn append(self: T) -> StoragePath<Mutable<Self::ElementType>> {
        Self::allocate(self)
    }

---

corelib/src/starknet/storage/vec.cairo line 446 at r2 (raw file):

        self.as_ptr().write(vec_len + 1);
        self.update(vec_len)
    }

---

corelib/src/starknet/storage/vec.cairo line 505 at r2 (raw file):

    fn append(self: T) -> StoragePath<Mutable<VecTraitImpl::ElementType>> {
        self.as_path().append()
    }

[orizi]

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @dean-starkware)

---

corelib/src/starknet/storage/vec.cairo line 324 at r2 (raw file):

    /// ```
    #[deprecated(
        feature: "corelib-internal-use",

or something similar.

Suggestion:

        feature: "starknet-storage-deprecation",

---

corelib/src/starknet/storage/vec.cairo line 325 at r2 (raw file):

    #[deprecated(
        feature: "corelib-internal-use",
        note: "Use `core::starknet::storage::Vec::MutableVecTrait::allocate` instead",

the actual visible path.

Suggestion:

        note: "Use `core::starknet::storage::MutableVecTrait::allocate` instead",

[dean-starkware]

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @orizi)

---

corelib/src/starknet/storage/vec.cairo line 324 at r2 (raw file):

Previously, orizi wrote…

or something similar.

Done.

---

corelib/src/starknet/storage/vec.cairo line 325 at r2 (raw file):

Previously, orizi wrote…

the actual visible path.

Done.

---

corelib/src/starknet/storage/vec.cairo line 327 at r2 (raw file):

        note: "Use `core::starknet::storage::Vec::MutableVecTrait::allocate` instead",
    )]
    fn append(self: T) -> StoragePath<Mutable<Self::ElementType>>;

Nicely done.

---

corelib/src/starknet/storage/vec.cairo line 446 at r2 (raw file):

        self.as_ptr().write(vec_len + 1);
        self.update(vec_len)
    }

Done.

---

corelib/src/starknet/storage/vec.cairo line 505 at r2 (raw file):

    fn append(self: T) -> StoragePath<Mutable<VecTraitImpl::ElementType>> {
        self.as_path().append()
    }

Done.

[orizi]

Reviewed 3 of 3 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dean-starkware)

[gilbens-starkware]

Reviewed 1 of 1 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dean-starkware)

---

corelib/src/starknet/storage/vec.cairo line 500 at r5 (raw file):

    fn allocate(self: T) -> StoragePath<Mutable<VecTraitImpl::ElementType>> {
        self.as_path().append()

Suggestion:

allocate()

[dean-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

corelib/src/starknet/storage/vec.cairo line 500 at r5 (raw file):

    fn allocate(self: T) -> StoragePath<Mutable<VecTraitImpl::ElementType>> {
        self.as_path().append()

Done.

[gilbens-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dean-starkware)