Invalidate snapped_semantics.

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/test_data/snapshot line 329 at r1 (raw file):

  (v42: core::panics::PanicResult::<(core::integer::u32,)>) <- PanicResult::Err(v28)
End:
  Return(v24, v25, v42)

without the fix

Suggestion:

blk2:
Statements:
  (v34: core::integer::u32) <- core::array::array_len::<core::integer::u32>(v22)
  (v35: (core::integer::u32,)) <- struct_construct(v34)
  (v36: core::panics::PanicResult::<(core::integer::u32,)>) <- PanicResult::Ok(v35)
End:
  Return(v29, v30, v36)

blk3:
Statements:
  (v37: core::panics::PanicResult::<(core::integer::u32,)>) <- PanicResult::Err(v33)
End:
  Return(v29, v30, v37)

blk4:
Statements:
  (v38: core::panics::PanicResult::<(core::integer::u32,)>) <- PanicResult::Err(v28)
End:
  Return(v24, v25, v38)

[orizi]

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1482 at r1 (raw file):

            .add(ctx, &mut builder.statements);
            builder.update_ref(ctx, snapshot_param, original);
            builder.update_snap_ref(snapshot_param, snapped);

add doc about the ordering of these lines.

Code quote:

            builder.update_snap_ref(snapshot_param, snapped);

---

crates/cairo-lang-lowering/src/lower/block_builder.rs line 106 at r1 (raw file):

        self.changed_member_paths.insert(member_path);
    
    }

Suggestion:

        self.changed_member_paths.insert(member_path);
    }

[ilyalesokhin-starkware]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1482 at r1 (raw file):

Previously, orizi wrote…

add doc about the ordering of these lines.

Done.

[orizi]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/mod.rs line 1521 at r3 (raw file):

                    // TODO(TomerStaskware): make sure this is unreachable and remove
                    // `MemberPathLoop` diagnostic.
                    LoweringFlowError::Failed(ctx.diagnostics.report(stable_ptr, MemberPathLoop))

How's this related?

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/lower/mod.rs line 1521 at r3 (raw file):

Previously, orizi wrote…

How's this related?

the error location was kind of useless without this fix.
do you want this as a separate PR?

[orizi]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[TomerStarkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/test_data/snapshot line 249 at r3 (raw file):

    }

    clear_scores(ref array1);

array.pop_front().unwrap();
is enough
or even array1 = array![]

Code quote:

clear_scores(ref array1);

[ilyalesokhin-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/test_data/snapshot line 249 at r3 (raw file):

Previously, TomerStarkware wrote…

array.pop_front().unwrap();
is enough
or even array1 = array![]

Done.

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

[TomerStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)