-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made all basic derives be based on members. #7321
Conversation
95c2be4
to
4af16ed
Compare
4af16ed
to
d69f361
Compare
d69f361
to
f379979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 43 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-plugins/src/plugins/derive/mod.rs
line 203 at r2 (raw file):
let derived_trait_name = derived_trait.split("::").last().unwrap_or(derived_trait); format!( "impl {name}{derived_trait_name}<{generics}> of {derived_trait}::<{full_typename}>",
generics
can be empty.
Code quote:
<{generics}>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 43 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)
crates/cairo-lang-plugins/src/plugins/derive/mod.rs
line 203 at r2 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
generics
can be empty.
it can be - but doesn't really matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 43 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)
corelib/src/internal.cairo
line 21 at r2 (raw file):
} /// Helper to have the same outside signature as `DropWith` and `DestructWith`.
what is an outside signature?
Code quote:
outside signature
f379979
to
44a14d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 43 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)
corelib/src/internal.cairo
line 21 at r2 (raw file):
Previously, ilyalesokhin-starkware wrote…
what is an outside signature?
Done
I mostly mean that it would look the same as the other 2 for users.
the word "outside" is useless here.
renamel to "PanicDestructInferred"
0ca0006
to
a94d43a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 43 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-plugins/src/test_data/derive
line 51 at r4 (raw file):
a: A, b: B, }
Suggestion:
#[derive(Clone, Debug, Default, Destruct, Hash, PanicDestruct, PartialEq, Serde)]
struct TwoMemberStruct {
a: A,
b: B,
}
#[derive(Clone, Debug, Default, Destruct, Hash, PanicDestruct, PartialEq, Serde)]
struct TwoSameTypeMemberStruct {
a1: A,
a2: A,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 43 files at r1.
Reviewable status: 1 of 43 files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 43 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)
crates/cairo-lang-plugins/src/test_data/derive
line 51 at r4 (raw file):
a: A, b: B, }
Done.
6bb418a
to
11b3717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 23 of 43 files at r1, 2 of 3 files at r3, 16 of 16 files at r4, 2 of 2 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
11b3717
to
0b23449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 43 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
commit-id:602fc47a
0b23449
to
d22307f
Compare
Stack:
DeriveInfo
toPluginTypeInfo
. #7335Store
based on derive-info. #7334DeriveInfo
into utils. #7333