-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Iterator::any
and Iterator::all
.
#7365
Conversation
9fb4c9c
to
f965774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
corelib/src/iter/traits/iterator.cairo
line 424 at r1 (raw file):
/// `all()` takes a closure that returns `true` or `false`. It applies this closure to each /// element of the iterator, and if all of them return `true`, then so does `all()`. If they any /// of them return `false`, it returns `false`.
Suggestion:
/// `all()` takes a closure that returns `true` or `false`. It applies this closure to each
/// element of the iterator, and if all of them return `true`, then so does `all()`. If any
/// of them return `false`, it returns `false`.
commit-id:29be040b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)
corelib/src/iter/traits/iterator.cairo
line 424 at r1 (raw file):
/// `all()` takes a closure that returns `true` or `false`. It applies this closure to each /// element of the iterator, and if all of them return `true`, then so does `all()`. If they any /// of them return `false`, it returns `false`.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Stack:
Iterator::any
andIterator::all
. #7365 ⬅