Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Iterator::any and Iterator::all. #7365

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Added Iterator::any and Iterator::all. #7365

merged 1 commit into from
Mar 3, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Feb 27, 2025

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the spr/main/29be040b branch 2 times, most recently from 9fb4c9c to f965774 Compare February 27, 2025 12:42
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

@orizi orizi force-pushed the spr/main/29be040b branch from f965774 to 2386101 Compare March 3, 2025 07:20
@orizi orizi changed the base branch from spr/main/b085c2d2 to main March 3, 2025 07:20
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


corelib/src/iter/traits/iterator.cairo line 424 at r1 (raw file):

    /// `all()` takes a closure that returns `true` or `false`. It applies this closure to each
    /// element of the iterator, and if all of them return `true`, then so does `all()`. If they any
    /// of them return `false`, it returns `false`.

Suggestion:

    /// `all()` takes a closure that returns `true` or `false`. It applies this closure to each
    /// element of the iterator, and if all of them return `true`, then so does `all()`. If any
    /// of them return `false`, it returns `false`.

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)


corelib/src/iter/traits/iterator.cairo line 424 at r1 (raw file):

    /// `all()` takes a closure that returns `true` or `false`. It applies this closure to each
    /// element of the iterator, and if all of them return `true`, then so does `all()`. If they any
    /// of them return `false`, it returns `false`.

Done.

@orizi orizi force-pushed the spr/main/29be040b branch from 2386101 to 778ae48 Compare March 3, 2025 08:17
@orizi orizi enabled auto-merge March 3, 2025 08:22
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@orizi orizi added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 706494a Mar 3, 2025
92 checks passed
@orizi orizi deleted the spr/main/29be040b branch March 4, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants