Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versions in spec files and package.json #183

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix versions in spec files and package.json #183

merged 2 commits into from
Dec 7, 2023

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Dec 7, 2023 •
edited by ArielElp
Loading

This change is Reviewable

FabijanC added a commit to FabijanC/starknet-specs that referenced this pull request Dec 7, 2023
@FabijanC
Apply doc change from starkware-libs#183
f0de5e2
@ArielElp ArielElp self-requested a review December 7, 2023 13:04
ArielElp
ArielElp approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @FabijanC)

@ArielElp ArielElp merged commit 4966593 into starkware-libs:master Dec 7, 2023
@FabijanC FabijanC deleted the fix-version branch December 7, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielElp ArielElp ArielElp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatched versions in specification files
2 participants
@FabijanC @ArielElp