Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema conformance #231

Merged

Conversation

xJonathanLEI
Copy link
Contributor

@xJonathanLEI xJonathanLEI commented Oct 6, 2024

The new changes from v0.7.1 to v0.8.0-rc0 are not consistent with the rest of the document. This PR fixes these issues:

  • missing required field on a few object schemas;
  • the TXN_STATUS_RESULT schema is incorrectly wrapped in another schema field;
  • a type of titel contained in CONTRACT_EXECUTION_ERROR.

This change is Reviewable

@ArielElp ArielElp self-requested a review October 7, 2024 06:43
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @xJonathanLEI)

@ArielElp ArielElp merged commit 1f387e5 into starkware-libs:v0.8.0 Oct 7, 2024
@xJonathanLEI xJonathanLEI deleted the fix/0_8_0_schema_conformance branch October 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants