Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytecode_segment_lengths indentation; Fix Immediate title #239

Conversation

franciszekjob
Copy link

@franciszekjob franciszekjob commented Oct 30, 2024

Minor fixes in starknet_executables.json.

  • Fix indentation of bytecode_segment_lengths in CASM_COMPILED_CONTRACT_CLASS
  • Fix title of Immediate

This change is Reviewable

@franciszekjob franciszekjob changed the base branch from master to v0.8.0 October 30, 2024 15:59
@ArielElp ArielElp self-requested a review November 6, 2024 09:30
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @franciszekjob)

@ArielElp ArielElp merged commit 2abbd5f into starkware-libs:v0.8.0 Nov 6, 2024
@franciszekjob franciszekjob deleted the franciszekjob/fix-starknet-executables-indentation branch November 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants