Merge pull request #76 from starkware-libs/add_replaced_classes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state update: add replaced classes and rename properties (#76)
ArielElp
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EvyatarO)
api/starknet_api_openrpc.json line 970 at r1 (raw file):
} }, "replaced_classes": {
not sure why those changes are here?
api/starknet_trace_api_openrpc.json line 103 at r1 (raw file):
}, { "$ref": "#/components/errors/INVALID_MESSAGE_SELECTOR"
can you also remove from the methods throwing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state update: add replaced classes and rename properties (#76)
This change is