also pack attestations where LMD vote is orphaned #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `attestation.data.beacon_block_root` gets orphaned, attestations with a good `attestation.data.target.root` may still be valuable. The LMD GHOST vote is not relevant for attestation rewards. Switch to use the FFG vote (`attestation.data.target.root`) instead, gossip validation ensures it is an ancestor of `beacon_block_root`.
arnetheduck
reviewed
Jun 4, 2023
Comment on lines
+546
to
+547
| attestedBlck = dag.getBlockRef(attestation.data.target.root).valueOr: | ||
| return err("Unknown `target.root`") |
There was a problem hiding this comment.
this can also be:
? dag.getBlockRef(...).orErr("Unknown...")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
attestation.data.beacon_block_rootgets orphaned, attestations with a goodattestation.data.target.rootmay still be valuable. The LMD GHOST vote is not relevant for attestation rewards.Switch to use the FFG vote (
attestation.data.target.root) instead, gossip validation ensures it is an ancestor ofbeacon_block_root.