Add metadata for the Holesky network #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
force-pushed
the
holesky-metadata
branch
from
d2dfaa3 to
3f6ed97
Compare
arnetheduck
reviewed
Sep 7, 2023
| of BakedIn: | ||
| @(metadata.bakedBytes) | ||
| of BakedInUrl: | ||
| decodeFramed(await downloadFile(parseUri metadata.url)) |
There was a problem hiding this comment.
when fetching from url, we need to validate the ssz root of the genesis else we can be fed anything - also, when doing TNS, we should be attempting to fetch it from the TNS source
* Bump Chronos to fix downloading from Github * Add checksum check of the downloaded file * Clean up debugging code and obsolete imports
zah
force-pushed
the
holesky-metadata
branch
from
145f8cc to
89d2a98
Compare
arnetheduck
reviewed
Sep 8, 2023
| vendorDir & "/holesky/custom_config_data", | ||
| some holesky, | ||
| downloadGenesisFrom = some DownloadInfo( | ||
| url: "https://github.com/status-im/nimbus-eth2/releases/download/v23.8.0/holesky-genesis.ssz.snappy-framed", |
There was a problem hiding this comment.
the extension for framed snappy is generally .sz: https://github.com/google/snappy/blob/main/framing_format.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.