Fix BytesN to ScVal conversion in testutils #1442
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
leighmcculloch
changed the title
sisuresh
approved these changes
Feb 25, 2025
|
Build failure being fixed by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change BytesN to ScVal conversion from TryFrom to From in test utilities.
Why
Unwrapping is safe because values in test environment must be valid ScVal. Even if this was wrong, it's a good tradeoff that improves the developer experience. The Bytes->ScVal and String->ScVal conversions already use this pattern and it seems BytesN wasn't updated at the same time to use that pattern.