-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): get to handle .cts files #6199
Conversation
hey @christian-bromann - do we need to add the
Do we also need to update this line too to cope with these types? Line 50 in e2965e5
Then I wonder if we could use one of these utils to replace all the inline checks in the if statements? |
@johnjenkins good catch, I reorganised some stuff around, wdyt? |
@christian-bromann - just some ideas .. perhaps practically they can't work 'cos the code exists at different times or whatever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presume my micro suggestions aren't workable / not practical? Tiny thing anyway - LGTM 🙂
I wasn't quite sure what you were referring to but you are right, updated the PR. |
What is the current behavior?
fixes #6198
What is the new behavior?
Considers
.cts
files now as well.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a