fix(trash-win): don't hang when shellslash
is enabled
#592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590
For some reason beyond my understanding, at least one of the following
things requires
noshellslash
to avoid the embeded powershell process tosend only
""
to the stdout (never calling the callback because"===DONE(True)==="
is never sent to stdout)vim.fn.jobstart
cmd.exe
powershell.exe
shellslash
has been removed from Neovim nightly so I didn't put that much time into investigating why or how this is happening.