Update action dist #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
commented
Dec 8, 2022
| @@ -35,8 +35,7 @@ jobs: | |||
| key: ${{ runner.os }}-node-16-action-${{ hashFiles('yarn.lock') }} | |||
| - name: Install dependencies | |||
| run: | | |||
| cd action | |||
| yarn install | |||
| yarn install --frozen-lockfile | |||
There was a problem hiding this comment.
Currently, the github action cache step does not work. This is because after cd into the directory, yarn will install local dependencies under action. Even though the node_modules exists under the root directory, it is not used.
There was a problem hiding this comment.
Looks like the cache still does not work with the new working directory.
|
Merge this now to fix production. Will look into the cache later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.