Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action dist #34

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Update action dist #34

merged 3 commits into from
Dec 8, 2022

Conversation

tuliren
Copy link
Member

@tuliren tuliren commented Dec 8, 2022

No description provided.

@@ -35,8 +35,7 @@ jobs:
key: ${{ runner.os }}-node-16-action-${{ hashFiles('yarn.lock') }}
- name: Install dependencies
run: |
cd action
yarn install
yarn install --frozen-lockfile
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the github action cache step does not work. This is because after cd into the directory, yarn will install local dependencies under action. Even though the node_modules exists under the root directory, it is not used.

Copy link
Member Author

@tuliren tuliren Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the cache still does not work with the new working directory.

@tuliren tuliren changed the title Fix github action cache and package check Update action dist Dec 8, 2022
@stoat-app
Copy link

stoat-app bot commented Dec 8, 2022

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
CLI Test Coverage Visit 40c7d5a
Action Test Coverage Visit 40c7d5a

Job Runtime

debug

@tuliren tuliren marked this pull request as ready for review December 8, 2022 18:03
@tuliren
Copy link
Member Author

tuliren commented Dec 8, 2022

Merge this now to fix production. Will look into the cache later.

@tuliren tuliren requested a review from jrhizor December 8, 2022 18:03
@tuliren tuliren merged commit 799dfe7 into main Dec 8, 2022
@tuliren tuliren deleted the liren/fix-package branch December 8, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant