Mark the job runtime plugin config as nullable

[tuliren]

Summary

• Mark job_runtime as nullable.
• Replace null plugin config with empty objects.
• This is necessary because on the server side, we merge all runtime into only array. However, if the config is null, deepmerge will only keep the last value.
  • For example, when merging these objects with a null field:

    deepmerge({ a: null }, { a: { runtime: [1] } }, { a: { runtime: [2] } })
    // { a: { runtime: [2] } }

  • In contrast, when the object is empty:

    deepmerge({ a: {} }, { a: { runtime: [1] } }, { a: { runtime: [2] } })
    // { a: { runtime: [1, 2] } }

  • We need to keep all the values. So the conversion is necessary.

This PR resolves #32.

[stoat-app]

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name	Link	Commit	Status
Documentation	Visit	788fa95	✅
Action Test Coverage	Visit	788fa95	✅
Action Test Coverage (single file)	Visit	788fa95	✅

Job Runtime

[jrhizor]

It's kind of unfortunate that it needs to be wrapped.

[tuliren]

It's kind of unfortunate that it needs to be wrapped.

The alternative solution is to provide a custom merging function to deepmerge. But I think the current solution is good enough, as long as we have clear comments and test cases.

[tuliren]

Actually let me just try the custom merging function approach if it is really quick.

[tuliren]

After a second thought, I think the current approach is better, because deepmerge is performed both on the server side and in the local mode. If we introduce a custom merging logic, we need to ensure that the logic is consistent in both places. With the current approach, that's not a concern.