Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #48

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Upgrade all dependencies #48

merged 8 commits into from
Dec 13, 2022

Conversation

tuliren
Copy link
Member

@tuliren tuliren commented Dec 12, 2022

  • Run yarn upgrade --latest for action and cli to keep all dependencies up-to-date.
  • We should do this regularly.

@stoat-app
Copy link

stoat-app bot commented Dec 12, 2022

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
CLI Test Coverage Visit f3ccf93
Action Test Coverage Visit f3ccf93
Action Test Coverage (single file) Visit f3ccf93

Job Runtime

debug

@tuliren
Copy link
Member Author

tuliren commented Dec 12, 2022

@jrhizor, the cli unit test is currently failing because 1) jest was not installed in this project, and 2) the infamous Cannot use import statement outside a module issue.

https://github.com/stoat-dev/stoat-action/actions/runs/3672963749/jobs/6209610754

I guess it is because of the removal of the yarn workspace. Do you remember how the project was setup before the introduction of yarn workspace? If not, I can dig into it.

(The cli test was not run regularly because the action config had a syntax error.)

@tuliren tuliren requested a review from jrhizor December 12, 2022 05:30
Chalk 5.x is a pure ESM, and cannot be used with TypeScript or with a build tool.

https://github.com/chalk/chalk/blob/v5.0.0/readme.md
@tuliren
Copy link
Member Author

tuliren commented Dec 13, 2022

The issue was that chalk 5.x is pure ESM. We need to stick with chalk 4.x.

@tuliren tuliren merged commit 898a3f1 into main Dec 13, 2022
@tuliren tuliren deleted the liren/upgrade-all-dependencies branch December 13, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant