Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run job runtime plugin by default #49

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Run job runtime plugin by default #49

merged 3 commits into from
Dec 13, 2022

Conversation

tuliren
Copy link
Member

@tuliren tuliren commented Dec 12, 2022

No description provided.

@stoat-app
Copy link

stoat-app bot commented Dec 12, 2022 •
edited
Loading

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
Action Test Coverage Visit 469c726 ✅
Action Test Coverage (single file) Visit 469c726 ✅

Job Runtime

debug

@tuliren tuliren marked this pull request as ready for review December 13, 2022 07:26
@tuliren tuliren requested a review from jrhizor December 13, 2022 07:27
jrhizor
jrhizor approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As we discussed, it would be ideal to not have default-job-runtime be an implicit task id, but this seems like the best way to expedite recording runtimes by default.

@tuliren tuliren merged commit c11a5d4 into main Dec 13, 2022
@tuliren tuliren deleted the liren/run-job-runtime-by-default branch December 13, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @jrhizor