Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor docs structure #77

Merged
merged 28 commits into from
Dec 17, 2022
Merged

refactor docs structure #77

merged 28 commits into from
Dec 17, 2022

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Dec 16, 2022

Refactor our docs to separate out pitching to different personas, core concepts, and use-case-based tutorials. Also quite a few cleanups.

  • docs/intro.md
  • docs/concepts/local-previews.md
  • docs/concepts/aggregation.md
  • docs/concepts/templating.md
  • docs/concepts/static-hosting.mdx
  • docs/concepts/configuring.md
  • docs/tutorials/build-runtimes.md
  • docs/tutorials/view-reports.md
  • docs/tutorials/create-and-update-comment.md
  • docs/tutorials/index.mdx
  • docs/tutorials/preview-components.mdx
  • docs/tutorials/preview-images.mdx
  • docs/tutorials/preview-videos.md
  • docs/tutorials/preview-docs.mdx
  • docs/tutorials/static-hosting/jest.mdx (should remove)
  • docs/tutorials/static-hosting/jacoco.mdx (should remove)
  • docs/tutorials/static-hosting/docusaurus.mdx (should remove)
  • docs/partials/_persona_list.mdx
  • docs/partials/_tip_use_cli.mdx (should remove)
  • docs/partials/_pricing_table.mdx
  • docs/partials/_tutorial_list.mdx
  • docs/installation.mdx
  • docs/why-stoat/python.md
  • docs/why-stoat/index.mdx
  • docs/why-stoat/managers.md
  • docs/why-stoat/javascript.md
  • docs/why-stoat/java.md
  • docs/why-stoat/devops.md
  • docs/company/pricing.mdx
  • docs/company/vision.md
  • docs/company/roadmap.md
  • docs/company/contact-us.md
  • docs/company/team.md
  • docs/company/updates.md

@stoat-app
Copy link

stoat-app bot commented Dec 16, 2022

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
Documentation Visit 955b606

Job Runtime

debug

@jrhizor jrhizor marked this pull request as ready for review December 17, 2022 00:28
@jrhizor jrhizor requested a review from tuliren December 17, 2022 00:28
Copy link
Member

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

One nitpick is should we check the images into the repo? One concern I have always had about this practice is that these images may be updated pretty frequently, but they will stay in the history of the codebase forever, making the size of the codebase unnecessary large. Personally I think that uploading them to GitHub issues (without creating the issue) and reference the links generated by GitHub is better.

@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 17, 2022

My main problem with the GitHub links was the lack of a file-like management system or an easy way to tell which files were which. I ended up uploading to a stoat-dev/static directory on the s3 bucket so they can be accessed with:
https://stoat-dev--static.stoat.page/screenshot-documentation.png

Then we have an understandable URL, we store the images by reasonable names, and we have a place where we can update images in place and have them appear in docs if we want a new version.

@jrhizor jrhizor merged commit faf7128 into main Dec 17, 2022
@jrhizor jrhizor deleted the jrhizor/refactor-docs branch December 17, 2022 11:01
@tuliren tuliren mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants