Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change config file format to use plugins.static_hosting.task_id instead of tasks.task_id.static_hosting #86

Merged
merged 9 commits into from
Dec 21, 2022

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Dec 20, 2022

I'm not planning on separating out the partial config merge key into something separate than the current aggregation method which depends on task id, so this implicitly adds a "stoat_job_runtime" dependency.

Job stats tracking is enabled by default at the action level unless plugins.job_runtime.tracking = false. Job stats view rendering requires enabling by setting plugins.job_runtime.enabled = true. The CLI now adds this by default.

  • server pr
  • bump/publish CLI version

@jrhizor jrhizor requested a review from tuliren December 20, 2022 23:48
@stoat-app
Copy link

stoat-app bot commented Dec 20, 2022

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
test_coverage_cli Visit 7871566
test_coverage_action_single_file Visit 7871566
test_coverage_action Visit 7871566
docs Visit 7871566

Job Runtime

debug

@stoat-app
Copy link

stoat-app bot commented Dec 21, 2022

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
Documentation Visit 8b67417
CLI Test Coverage Visit 8b67417
Action Test Coverage Visit 8b67417
Action Test Coverage (single file) Visit 8b67417

Job Runtime

debug

@jrhizor jrhizor marked this pull request as ready for review December 21, 2022 00:54
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs 🔄 Building (Inspect) Dec 21, 2022 at 2:20AM (UTC)

@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 21, 2022

Copy link
Member

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks like the new config also simplified the code a little bit.

@tuliren
Copy link
Member

tuliren commented Dec 21, 2022

Once I merge, @tuliren can you update:

Of course.

Also https://github.com/tuliren/storybook-code-coverage is replaced by https://github.com/stoat-dev/example-javascript. I will delete my repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants