Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2-cat-gifs edit problem copy #19

Closed
wants to merge 2 commits into from
Closed

2-cat-gifs edit problem copy #19

wants to merge 2 commits into from

Conversation

hakierka
Copy link
Contributor

@hakierka hakierka commented Aug 2, 2024

Pull Request Description:

This pull request improves the instructions for Challenge 2 by providing clearer guidance on how to upload a file using the files-from-path module. It addresses the issues with the previous instructions, clarifying the purpose of the module and ensuring users understand where and how to use the files.

Changes Made:

  • Added detailed explanations on why the files-from-path module is needed.
  • Clarified the steps to find and specify a cat meme file for uploading.
  • Updated the code example to match the improved instructions.

@hakierka hakierka closed this Aug 5, 2024
alanshaw
alanshaw requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you this is great!

We're not using ; in code samples here (or anywhere for that matter unless strictly necessary), could you please do a pass to remove them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakierka @alanshaw