Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few code exaples to documentation #194

Merged

Conversation

vojtechtrefny
Copy link
Member

Libblockdev initialization and using the extra args (BDExtraArg)
is quite complicated so add some code snippets to demonstrate
usage of this functionality.

Copy link
Collaborator

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Thanks!

@@ -375,6 +375,20 @@ GQuark bd_init_error_quark ()
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libblockdev in the commit message (all lower case)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

libblockdev initialization and using the extra args (BDExtraArg)
is quite complicated so add some code snippets to demonstrate
usage of this functionality.
@vojtechtrefny vojtechtrefny force-pushed the master_docs-code-snippets branch from 1f8caee to c852d72 Compare May 29, 2017 11:17
@vpodzime vpodzime merged commit 15a063e into storaged-project:master May 29, 2017
tbzatek added a commit to tbzatek/libblockdev that referenced this pull request May 2, 2024
Libatasmart' temperature_cb() as iterated via sk_disk_smart_get_temperature()
goes through the table and only the last available value
of four matched attributes is reported back to the caller.
This is different from smartmontools which defines matching
priority.

While there are four attributes to be matched, the latter two
are actually overrides from the standard set. This is where
drivedb comes into play, however for the moment we don't have
forward checking. Thus only match storaged-project#194 and storaged-project#190, which are
typically safe.
tbzatek added a commit to tbzatek/libblockdev that referenced this pull request May 27, 2024
Libatasmart' temperature_cb() as iterated via sk_disk_smart_get_temperature()
goes through the table and only the last available value
of four matched attributes is reported back to the caller.
This is different from smartmontools which defines matching
priority.

While there are four attributes to be matched, the latter two
are actually overrides from the standard set. This is where
drivedb comes into play, however for the moment we don't have
forward checking. Thus only match storaged-project#194 and storaged-project#190, which are
typically safe.
tbzatek added a commit to tbzatek/libblockdev that referenced this pull request May 27, 2024
Libatasmart' temperature_cb() as iterated via sk_disk_smart_get_temperature()
goes through the table and only the last available value
of four matched attributes is reported back to the caller.
This is different from smartmontools which defines matching
priority.

While there are four attributes to be matched, the latter two
are actually overrides from the standard set. This is where
drivedb comes into play, however for the moment we don't have
forward checking. Thus only match storaged-project#194 and storaged-project#190, which are
typically safe.
tbzatek added a commit to tbzatek/libblockdev that referenced this pull request May 27, 2024
Libatasmart' temperature_cb() as iterated via sk_disk_smart_get_temperature()
goes through the table and only the last available value
of four matched attributes is reported back to the caller.
This is different from smartmontools which defines matching
priority.

While there are four attributes to be matched, the latter two
are actually overrides from the standard set. This is where
drivedb comes into play, however for the moment we don't have
forward checking. Thus only match storaged-project#194 and storaged-project#190, which are
typically safe.
vojtechtrefny pushed a commit that referenced this pull request Jul 24, 2024
Libatasmart' temperature_cb() as iterated via sk_disk_smart_get_temperature()
goes through the table and only the last available value
of four matched attributes is reported back to the caller.
This is different from smartmontools which defines matching
priority.

While there are four attributes to be matched, the latter two
are actually overrides from the standard set. This is where
drivedb comes into play, however for the moment we don't have
forward checking. Thus only match #194 and #190, which are
typically safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants