fix triggers #1033
Merged
fix triggers #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcheung-stripe
approved these changes
Feb 17, 2023
|
I wasn't sure how to test the updated CLI so I made the same changes in Shell and tested those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
Updates the checkout.session.async_payment_failed.json and checkout.session.async_payment_succeeded.json fixtures so that it works for a larger set of our merchants who are either in US or Europe instead of just UK merchants.
Motivation
https://admin.corp.stripe.com/team-run/boards/RUN_DX/preview/RUN_DX-1652
Test plan
Rollout/monitoring/revert plan
Safe to revert unless specified otherwise