adding user configurable read timeouts

[joyluu-stripe]

Reviewers

r? @etsai-stripe
cc @stripe/developer-products

Summary

Allows user to set timeout in config file using a hidden flag (ex. stripe listen --timeout xx); if not set, defaults to 30 seconds as it was before.

[etsai-stripe]

we can only need Timeout stored in either Config or Profile (Profile is already a field in Config). Config makes more sense imo, since Profile is more user account related values.
what we need is something like

func (c *Config) GetTimeout() int64 {
	// return customized timeout or default timeout
}

[joyluu-stripe]

we can only need Timeout stored in either Config or Profile (Profile is already a field in Config). Config makes more sense imo, since Profile is more user account related values. what we need is something like

func (c *Config) GetTimeout() int64 {
	// return customized timeout or default timeout
}

gotcha, made that change! I still kept the get function in Profile since the color config seems to do the same thing (hope that's okay!) also realized that we can keep default timeout for cases where no httpClient is passed in, since that's where we pass timeout through.

[etsai-stripe]

ohh now i see why you tried to add timeout to profile. if you want to follow the way color is set on profile, lets keep everything consistent.

1. we dont need Config.GetTimeout. we can just keep Profile.GetTimeout (sorry for the confusion earlier), but timeout field should still live only on config struct like how color does.
2. we dont need timeout added to proxy.Config. we can pass profile.GetTimeout to the HttpClient
3. add timeout flag to rootcmd. see example here: https://github.com/stripe/stripe-cli/blob/master/pkg/cmd/root.go#L141

[joyluu-stripe]

doesn't seem like there's a need to add the private flag to here actually? it seems like there's only one call to proxy.init and most parameters are getting passed default values

[etsai-stripe]

could you please explain why we need to pass this in proxy.config?

[joyluu-stripe]

ah, i was thinking it would be more consistent with how the other hidden flags' values are passed (like noWSS and apiBaseUrl are passed this way into proxy as well).

[etsai-stripe]

thanks for making all the changes!